-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to instruct how to alias the native one (due to Node 22 annoying warning) #137
Comments
Nowadays we publish the package both as |
You can't in 3rd party modules, that are deep inside your
Say you got rid of node-fetch:
Now it's It just keeps going. |
Seriously good grief, who started this insanity? Getting this deprecation warning removed is near impossible from the amount of usage. |
|
The amount of packages which rely on this is insane. Getting rid of this warning almost brought me to tears |
#303 Fix punycode warning. Used fix recommended in mathiasbynens/punycode.js#137
naofireblade#303 Fix punycode warning. Used fix recommended in mathiasbynens/punycode.js#137
* Fix threshold triggers naofireblade#296 Fix issue with threshold triggers and WeatherUnderground. In 3.3.4, WeatherUnderground API call was modified and incorrectly return values in km, and km/h * Fix punycode warning naofireblade#303 Fix punycode warning. Used fix recommended in mathiasbynens/punycode.js#137 * Fix util._extend warning Fix naofireblade#303 Though I could not reproduce the warning, this should fix it. * Migrate off request package naofireblade#150 Migrate off the deprecated request package and moved all URL loads to using the supported axios package. Tried to make as smaller changes as possible. Added a little more failure logging to enable better debugging. Found that punycode was only being used by request so I could remove the work around for it (naofireblade#303) Found that debug package wasn't explicitly being listed as a dependency in package.json, though index.js requires it, so added that. Tested with valid tokens - all worked (only tested openweathermap 2.5 API) Tested with invalid tokens - got correct error messages, didn’t crash HomeBridge Tested with bad URLs - got correct error messages, didn’t crash HomeBridge Migrated weewx weather station, though I wasn’t able to test it. * Update CHANGELOG.md naofireblade#150 Update Changelog * Changes for Homebridge 2.0 naofireblade#301 Initial fixes to make the plugin work with Homebridge 2.0 Two basic changes: 1. Use of enums off the Characteristic class is no longer supported: Instead of const Units = Characteristic.Units; you will need to use const Units = api.hap.Units; Instead of const Formats = Characteristic.Formats; you will need to use const Formats = api.hap.Formats; Instead of const Perms = Characteristic.Perms; you will need to use const Perms = api.hap.Perms; 2. Change custom characteristics to be classes with constructors, rather than using the inherits() functionality. * Change colons for Modifier Letter Triangular Colon naofireblade#301 Homekit has special rules for naming items. They must start with an alpha or numeric value, then they can contain alphanumeric characters, space and apostrophe, and they must end with an alpha or numeric character. The created sensors are using colons for delimiters, which isn't allowed. However, according to Apple documentation alphanumeric characters consist of Unicode character sets L*, M* and N*. The Modifier Letter Triangular Colon falls into the L* set, so it should be legal to use. See homebridge/HAP-NodeJS#1079 for more detail. --------- Co-authored-by: dacarson <[email protected]>
Why is this still a thing in 2025? I'm sick of seeing these errors. |
punycode
is deprecated, and a userland solution must be usednode_modules
use nativepunycode
and many are out of our control. It's too many. Especially becausenode-fetch
depends onpunycode
, and even if this itself is now native .... we all know what a chaos is innode_modules
.module-alias
and then add before anything else (node -r
or viaNODE_OPTIONS
):And it works.
I recommend adding this in the README. I can do it, if I know you will accept it.
The text was updated successfully, but these errors were encountered: