Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing pre-built PyPI wheels #2

Closed
tvercaut opened this issue Apr 5, 2022 · 5 comments
Closed

Consider providing pre-built PyPI wheels #2

tvercaut opened this issue Apr 5, 2022 · 5 comments

Comments

@tvercaut
Copy link

tvercaut commented Apr 5, 2022

To ease usage of the package in python, it would be nice to provide pre-built PyPI wheels. This can hopefully be nicely done by exploiting this work:
https://github.com/charliebudd/torch-extension-builder

@masadcv
Copy link
Owner

masadcv commented Apr 6, 2022

Many thanks! I have released binaries for v0.0.4 on pypi and github for windows and mac

This could not be done yet for ubuntu as pypi accepts manylinux binaries and pytorch has some issues with compiling these cleanly (see: pytorch/builder#468).

The workflow for generating these binaries is under https://github.com/masadcv/torchmaxflow/blob/main/.github/workflows/build-whl-publish.yml

I will switch to torch-extension-builder in coming days when CPU and Windows support is added in:
charliebudd/torch-extension-builder#14

and

charliebudd/torch-extension-builder#13

@masadcv
Copy link
Owner

masadcv commented Apr 6, 2022

binaries are available through pypi installation: https://pypi.org/project/torchmaxflow

@masadcv
Copy link
Owner

masadcv commented May 8, 2022

Closing this issue as pre-built binaries have been released.

@masadcv masadcv closed this as completed May 8, 2022
@dyollb
Copy link

dyollb commented Oct 22, 2022

Looking at the setup.py it seems this package does not provide a gpu implementation (there are no .cu files). Is this correct? If so, maybe a comment in the top-level readme would be nice.

@masadcv
Copy link
Owner

masadcv commented Oct 22, 2022

@dyollb yes that's correct, it does not provide GPU implementation. I will update readme to indicate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants