-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider providing pre-built PyPI wheels #2
Comments
Many thanks! I have released binaries for v0.0.4 on pypi and github for windows and mac This could not be done yet for ubuntu as pypi accepts manylinux binaries and pytorch has some issues with compiling these cleanly (see: pytorch/builder#468). The workflow for generating these binaries is under https://github.com/masadcv/torchmaxflow/blob/main/.github/workflows/build-whl-publish.yml I will switch to torch-extension-builder in coming days when CPU and Windows support is added in: and |
binaries are available through pypi installation: https://pypi.org/project/torchmaxflow |
Closing this issue as pre-built binaries have been released. |
Looking at the setup.py it seems this package does not provide a gpu implementation (there are no .cu files). Is this correct? If so, maybe a comment in the top-level readme would be nice. |
@dyollb yes that's correct, it does not provide GPU implementation. I will update readme to indicate this. |
To ease usage of the package in python, it would be nice to provide pre-built PyPI wheels. This can hopefully be nicely done by exploiting this work:
https://github.com/charliebudd/torch-extension-builder
The text was updated successfully, but these errors were encountered: