Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add bpmdetect #2172

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add bpmdetect #2172

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 13, 2024

BPMDetect is automatic BPM (beats per minute) detection utility.

Log: add software name--bpmdetect
bpmdetect

BPMDetect is automatic BPM (beats per minute) detection utility.

Log: add software name--bpmdetect
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-install.patch文件中,缺少了+符号,可能导致Patch无法正确应用。
  • install(TARGETS ${PROJECT_NAME} DESTINATION bin)中的${PROJECT_NAME}应该大写以匹配CMake的变量引用规则。
  • install(FILES src/bpmdetect-icon.png DESTINATION share/icons/hicolor/16X16/apps/)install(FILES src/bpmdetect.desktop DESTINATION share/applications)中的文件路径使用了相对路径,建议使用绝对路径以避免潜在的配置问题。

是否建议立即修改:

@kamiyadm kamiyadm merged commit 0b83fc0 into martyr-deepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants