Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python version collides with pipe "|" syntax #12

Open
RobinU434 opened this issue Jan 16, 2025 · 2 comments
Open

Python version collides with pipe "|" syntax #12

RobinU434 opened this issue Jan 16, 2025 · 2 comments

Comments

@RobinU434
Copy link
Contributor

Good evening,

during programming on the final project we encountered a small problem with the python version and current syntax which is not supported by older versions like 3.6 or 3.8. The problem hereby lies in the signature of HockeyEnv.__init__() method, where there was a pipe used to make something equivalent to Union[<type 1>, <type 2>] -> <type 1> | <type 2> as a union type annotation.

An easy fix would be either to increase the minimal python version until the point where it can support the pipe syntax. Another way would be to just convert <type 1> | <type 2> to Union[<type 1>, <type 2>].

Please let me know for option you would like to choose.

All the best, Robin

@RobinU434 RobinU434 changed the title Python version collides with pipe "|" Python version collides with pipe "|" syntax Jan 16, 2025
@georgmartius
Copy link
Collaborator

Let's just convert it into Union[...]
Just asking, who is using 3.6? 3.8 was used last year and I am confused. Did we add the type specifier with the last pull request. Anyway, no problem. Let's fix that.

@RobinU434
Copy link
Contributor Author

I was approached by a fellow student regarding a question with the cluster. As it turns out their container was running in python 3.8 (but now they use 3.12) and there the error occurred. So just to resolve this issue for people who could use 3.8 I opened up this issue. Thanks for the reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants