From e6118bb7f1a2c6bec955202cc64996e60396d64c Mon Sep 17 00:00:00 2001 From: Felix Kloss Date: Mon, 28 Oct 2024 13:46:08 +0100 Subject: [PATCH] Print warning when report generation failed. So far, a failure during report generation was logged but not printed to the terminal, so it could easily be missed by the user. To change this, also print an explicit, red warning to the terminal in that case. --- src/cluster_utils/server/report.py | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/cluster_utils/server/report.py b/src/cluster_utils/server/report.py index ae6a0f9..f5ed36a 100644 --- a/src/cluster_utils/server/report.py +++ b/src/cluster_utils/server/report.py @@ -22,7 +22,7 @@ from . import data_analysis, distributions from .latex_utils import LatexFile from .optimizers import Optimizer -from .utils import log_and_print, shorten_string +from .utils import log_and_print, make_red, shorten_string def init_plotting(): @@ -313,7 +313,12 @@ def filename_gen(base_path): latex.produce_pdf(output_file) log_and_print(logger, f"Report saved at {output_file}") except Exception: - logging.warning("Could not generate PDF report", exc_info=True) + logging.warning("Failed to generate PDF report", exc_info=True) + print( + make_red( + "Warning: Failed to generate PDF report. See log for details." + ) + ) def distribution_plots( @@ -494,4 +499,9 @@ def filename_gen(base_path: str | os.PathLike) -> Iterator[str]: latex.produce_pdf(output_file) logger.info("Saved report to %s", output_file) except Exception: - logger.warning("Could not generate PDF report", exc_info=True) + logger.warning("Failed to generate PDF report", exc_info=True) + print( + make_red( + "Warning: Failed to generate PDF report. See log for details." + ) + )