Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peer info to closing and close events #3

Open
martianboy opened this issue Sep 28, 2018 · 0 comments
Open

Add peer info to closing and close events #3

martianboy opened this issue Sep 28, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@martianboy
Copy link
Owner

Currently both Channel and Connection make no distinction between server or client closure when emitting close event, which is desirable in certain cases, e.g. cleanup after close. But there are certain use cases that the user might need to know which peer first sent the close request. In these cases we need to make it clear whether it was server (by an error or forced stopping), or it was the client.

@martianboy martianboy added the enhancement New feature or request label Sep 28, 2018
@martianboy martianboy self-assigned this Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant