Infinite re-rendering connected with defaultValue

[bookin]

Face in few places of my code with problem that when TextInput has defaultValue, or BooleanInput has disabled=true it give Infinite re-rendering.

As I understood problem somewhere in the - useApplyInputDefaultValues

The simplest example:

const Test: FC = () => {
	return (
		<SimpleForm>
			<BooleanInput
				label={'Chekbox'}
				source={'isCheckbox'}
				disabled={true}
			/>
		</SimpleForm>
	);
};

In this case I see infinite re-renders with warning - Warning: Cannot update a component (SaveButton) while rendering a different component (BooleanInput).

If use const form = useForm(); and <FormProvider {...form}> no warning, but still re-rendering

Error happens when disabled={true}, if set false it works

For TextInput I don't have example, I faced with it in using MUI DataGrid in the columns.renderCell. But I think problem the same.

Environment

• React-admin version: 5.4.2
• React version: 18.3.1
• Hook Form: 7.54.1

[djhi]

Thanks for reporting this. Please provide a sample application showing the issue, preferably a sandbox forked from

• https://codesandbox.io/p/github/marmelab/react-admin-sandbox/main (v5)
• https://stackblitz.com/github/marmelab/react-admin/tree/master/examples/simple (v5)
• https://stackblitz.com/github/marmelab/react-admin/tree/4.x/examples/simple (v4)

[slax57]

FTR: we had several issues in the past using disabled inputs with react-hook-form. That's why we introduced a readOnly prop on all input components, and we now recommend to use it instead of disabled.
It may solve your issue.

References:
#9498
#9378
#9365