Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Laravel 11 #33

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Add support for Laravel 11 #33

merged 2 commits into from
Mar 13, 2024

Conversation

eshimischi
Copy link
Contributor

No description provided.

@markwalet
Copy link
Owner

Thank you for the PR. I think the testbench dependency should be updated as well right? Did this install correctly locally?

Could you also add the new version to the test matrix?

@eshimischi
Copy link
Contributor Author

eshimischi commented Mar 13, 2024

Thank you for the PR. I think the testbench dependency should be updated as well right? Did this install correctly locally?

Could you also add the new version to the test matrix?

Need to check this. I would also update PhpUnit to 10 what Laravel is using (PHP 8.2, 8.3)

@eshimischi
Copy link
Contributor Author

eshimischi commented Mar 13, 2024

Testbench is not ready, they updated but not released 9.x version yet

PS: just release 9.x version

@eshimischi
Copy link
Contributor Author

eshimischi commented Mar 13, 2024

PhpUnit 10.x or even 11.x tests should be reworked i bet, for instance PhpUnit 10.x test 1 and PhpUnit 10.x test 2. As new PR.

@markwalet
Copy link
Owner

Alright, let me merge your PR and rework the test matrix myself a bit. Thanks for the PR 👍

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.24%. Comparing base (640cbac) to head (b4c8552).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage     94.24%   94.24%           
  Complexity       56       56           
=========================================
  Files            11       11           
  Lines           139      139           
=========================================
  Hits            131      131           
  Misses            8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markwalet markwalet merged commit 832241f into markwalet:master Mar 13, 2024
27 checks passed
@eshimischi eshimischi deleted the patch-1 branch March 13, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants