Improve code coverage

markwalet · Dec 15, 2021 · e95fbf6 · e95fbf6
1 parent cb260da
commit e95fbf6
Show file tree

Hide file tree

Showing 8 changed files with 26 additions and 24 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,15 @@
 
 ## [Unreleased](https://github.com/markwalet/laravel-git-state/compare/v1.4.0...master)
 
+## [v1.5.0 (2021-12-15)](https://github.com/markwalet/laravel-git-state/compare/v1.4.1...v1.5.0)
+
+### Added
+- Added PHP 8.1 support ([#18](https://github.com/markwalet/laravel-git-state/issues/18))
+
+### Changed
+- Used [`webmozart/assert`](https://github.com/webmozarts/assert) instead of custom logic to reduce complexity.
+- Simplified exception code style.
+
 ## [v1.4.1 (2020-10-19)](https://github.com/markwalet/laravel-git-state/compare/v1.4.0...v1.4.1)
 
 ### Added

diff --git a/src/Drivers/FileGitDriver.php b/src/Drivers/FileGitDriver.php
@@ -9,7 +9,7 @@
 class FileGitDriver implements GitDriver
 {
     /** @var string */
-    private $folder;
+    private string $folder;
 
     /**
      * GitDriverInterface constructor.
@@ -51,7 +51,7 @@ public function latestCommitHash(bool $short = false): string
         $path = $this->path('refs'.DIRECTORY_SEPARATOR.'heads'.DIRECTORY_SEPARATOR.$this->currentBranch());
 
         if (file_exists($path) === false) {
-            throw new RuntimeException($path);
+            throw new RuntimeException("File `$path` is not found.");
         }
 
         $hash = file_get_contents($path);

diff --git a/src/Exceptions/FileNotFoundException.php b/src/Exceptions/FileNotFoundException.php
diff --git a/src/Exceptions/RuntimeException.php b/src/Exceptions/RuntimeException.php
@@ -7,7 +7,7 @@
 class RuntimeException extends BaseRuntimeException
 {
     /**
-     * NoGitRepositoryException constructor.
+     * RuntimeException constructor.
      *
      * @param $message
      */

diff --git a/tests/Drivers/DriverTests.php b/tests/Drivers/DriverTests.php
@@ -64,4 +64,14 @@ public function it_can_get_the_latest_long_commit_hash_of_a_git_repository()
 
         $this->assertEquals('202131f0ba24d03d75667ce586be1c1ce3983ce8', $commit);
     }
+
+    /** @test */
+    public function it_throws_an_exception_when_the_head_file_is_not_found_for_the_latest_commit()
+    {
+        $this->expectException(RuntimeException::class);
+
+        $git = $this->driver('broken-head');
+
+        $git->latestCommitHash();
+    }
 }
diff --git a/tests/LaravelTestCase.php b/tests/LaravelTestCase.php
@@ -15,7 +15,7 @@ class LaravelTestCase extends TestCase
      *
      * @return array
      */
-    protected function getPackageProviders($app)
+    protected function getPackageProviders($app): array
     {
         return [
             GitStateServiceProvider::class,

diff --git a/tests/test-data/broken-head/HEAD b/tests/test-data/broken-head/HEAD
@@ -0,0 +1 @@
+ref: refs/heads/master
diff --git a/tests/test-data/broken-head/objects/.gitignore b/tests/test-data/broken-head/objects/.gitignore
@@ -0,0 +1,2 @@
+*
+!.gitignore