Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A number of issues from first time testing #26

Open
ragingdave opened this issue May 6, 2021 · 2 comments
Open

A number of issues from first time testing #26

ragingdave opened this issue May 6, 2021 · 2 comments
Assignees
Labels
needs-info Further information is requested

Comments

@ragingdave
Copy link

ragingdave commented May 6, 2021

So there are a number of issues I hit when just trying to test this, so constructively I figured I would lay them out here.

  1. When initially trying to use the package and run artisan changelog:add it fails with a folder creation error. This seems to be due to both .changes and .changes/unreleased not already existing and after manually adding the whole folder structure, it added an xml changelog.
  2. When trying to generate a release, I ran changelog:release, and that worked but no changelog was generated. This was confusing and I had to run changelog:generate separately just to get a changelog added.
  3. Following the last step, the changelog didn't have any content other than the release version I had specified, and the tagline about being generated by this package.
  4. On a subsequent attempt to run changelog:add I was hit by another folder creation error and that's about where I stopped.

Here is the whole command list I ran to get to this point:

 mkdir .changes
mkdir .changes/unreleased
artisan changelog:add -v --type=added --message "add new feature"
artisan change:list # This list just said unreleased without the change I had just added
artisan changelog:release 5.15.0
artisan changelog:generate

Contents of the generated CHANGELOG.md:

# Release Notes


## [5.15.0]

This file was generated by [markwalet/laravel-changelog](https://github.com/markwalet/laravel-changelog)

It's potentially worth noting that I'm using the gitflow workflow, so the branch I am on is in the format of feature/<TICKET> as I wonder if the nesting is causing an issue.

OH and one last thing, I already had a changelog in place which this command overwrote so it's also worth noting that you can't use this with an already present CHANGELOG.md

@markwalet
Copy link
Owner

Thank you for your feedback! I will review your issues later this week when things have calmed down at the office :)

@markwalet markwalet self-assigned this May 19, 2021
markwalet added a commit that referenced this issue Jun 1, 2021
@markwalet
Copy link
Owner

Nested branch names (used in the gitflow workflow) are supported since v1.6.1. Can you check if other issues are resolved now?

@markwalet markwalet added the needs-info Further information is requested label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-info Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants