Skip to content

Commit

Permalink
fix acceptance test for $post_update_cmd/$update_enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
fraenki committed Nov 5, 2022
1 parent c5d1c67 commit 7a6e1f1
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 10 deletions.
17 changes: 9 additions & 8 deletions .fixtures.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@
---
fixtures:
repositories:
"archive": "https://github.com/voxpupuli/puppet-archive.git"
"cron_core": "https://github.com/puppetlabs/puppetlabs-cron_core.git"
"facts": "https://github.com/puppetlabs/puppetlabs-facts.git"
"php": "https://github.com/voxpupuli/puppet-php.git"
"provision": "https://github.com/puppetlabs/provision.git"
"puppet_agent": "https://github.com/puppetlabs/puppetlabs-puppet_agent.git"
"stdlib": "https://github.com/puppetlabs/puppetlabs-stdlib"
facts: "https://github.com/puppetlabs/puppetlabs-facts.git"
provision: "https://github.com/puppetlabs/provision.git"
puppet_agent: "https://github.com/puppetlabs/puppetlabs-puppet_agent.git"
forge_modules:
archive: "puppet/archive"
cron_core: "puppetlabs/cron_core"
php: "puppet/php"
stdlib: "puppetlabs/stdlib"
symlinks:
nextcloud: "#{source_dir}"
nextcloud: "#{source_dir}"
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Changed
* Only extract the Nextcloud tarball when `$install_enabled` is set to `true`

### Fixed
* Post update command was not run if `$update_enabled` was set to `false`

## [v1.7.0] - 2022-09-21

### Changed
Expand Down
3 changes: 2 additions & 1 deletion manifests/update.pp
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@
"\$( ${nextcloud::date_expression} )",
], ' ')

# Run the post-update command.
# Run the post-update command. These commands are expected to run
# on all hosts (not just on $update_host).
exec { 'post-update command':
command => $nextcloud::post_update_cmd,
path => $nextcloud::path,
Expand Down
2 changes: 1 addition & 1 deletion spec/acceptance/nextcloud_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class { 'nextcloud':
system_group => $group_name,
system_user => 'nobody',
# The post-update command would break the idempotency test.
update_enabled => false,
update_enabled => 'none',
version => '24.0.6',
}
EOS
Expand Down

0 comments on commit 7a6e1f1

Please sign in to comment.