fix: handle TOML parsing errors in config reader #3671
Merged
+41
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Add error handling for tomlkit.exceptions.TOMLKitError - Add tests for valid and invalid TOML parsing - Fixes #3668 Co-Authored-By: Myles Scolnick <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Co-Authored-By: Myles Scolnick <[email protected]>
mscolnick
approved these changes
Feb 3, 2025
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.20-dev19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TOML parsing errors in config reader
This PR fixes an issue where invalid TOML files would cause unhandled exceptions. Now, when a TOML file has parsing errors, the code will gracefully fall back to the default configuration.
Changes:
tomlkit.exceptions.TOMLKitErrorFixes #3668
Link to Devin run: https://app.devin.ai/sessions/60a00d7d6a1c4b51b42a0acc2898c9b7
Requested by: Myles
Testing: