Test for fontFamily results in incorrect warnings

[milovanderlinden]

In

https://github.com/mapfish/mapfish-print/blob/master/src/main/java/org/mapfish/print/map/renderers/vector/LabelRenderer.java

The fontFamily is tested like this:

if (!"COURIER".equalsIgnoreCase(fontFamily)
                    || !"HELVETICA".equalsIgnoreCase(fontFamily)
                    || !"TIMES_ROMAN".equalsIgnoreCase(fontFamily)) {

                LOGGER.info("Font: '"+ fontFamily +
                        "' not supported, supported fonts are 'HELVETICA', " +
                        "'COURIER', 'TIMES_ROMAN', defaults to 'HELVETICA'");
                fontFamily = "HELVETICA";
            }

This is wrong, as the test will always return True since a given fontFamily will never match all three fontFamilies

The correct could would be:

if (!"COURIER".equalsIgnoreCase(fontFamily)
                    && !"HELVETICA".equalsIgnoreCase(fontFamily)
                    && !"TIMES_ROMAN".equalsIgnoreCase(fontFamily)) {

                LOGGER.info("Font: '"+ fontFamily +
                        "' not supported, supported fonts are 'HELVETICA', " +
                        "'COURIER', 'TIMES_ROMAN', defaults to 'HELVETICA'");
                fontFamily = "HELVETICA";
            }