Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create method on ViewModelFactory could more Kotlin-like #4

Open
henriquehorbovyi opened this issue Sep 10, 2019 · 1 comment
Open

create method on ViewModelFactory could more Kotlin-like #4

henriquehorbovyi opened this issue Sep 10, 2019 · 1 comment

Comments

@henriquehorbovyi
Copy link

It would be better to use when expression to increase readability on this part of your code.

image

I'd like to open a PR for that 😄
@henriquehorbovyi
Copy link
Author

Or this code will be removed after this PR? #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henriquehorbovyi