Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When attaching the release asset, we overwrite the changelog in the release #124

Open
1 task done
dkotter opened this issue Jan 30, 2025 · 0 comments
Open
1 task done
Labels
type:bug Something isn't working.
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented Jan 30, 2025

Describe the bug

In #97 we switched from using the deprecated actions/upload-release-asset to softprops/action-gh-release. While doing the latest release, this worked great to attach the release asset but noticed it also overwrote the entire contents of the release itself to just say This release contains the latest updates for the WordPress plugin.

It looks like that's coming from these lines:

body: |
This release contains the latest updates for the WordPress plugin.

I've updated the release to add back the changelog information but ideally we fix this before the next release so we don't run into the same problem

Steps to Reproduce

n/a

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dkotter dkotter added the type:bug Something isn't working. label Jan 30, 2025
@dkotter dkotter added this to the 1.7.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

1 participant