From 8cc47fba5a91777044a9198026d9d02f46278a04 Mon Sep 17 00:00:00 2001 From: gonzalo Date: Mon, 8 Apr 2024 11:20:17 -0300 Subject: [PATCH] closes #1951 for magento 2.1 --- Model/Api/Order.php | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/Model/Api/Order.php b/Model/Api/Order.php index 77d23dbc..009ac0b5 100644 --- a/Model/Api/Order.php +++ b/Model/Api/Order.php @@ -86,7 +86,6 @@ class Order protected $_counter; protected $_batchId; - protected $modifiedOrder = false; /** * @param \Ebizmarts\MailChimp\Helper\Data $helper @@ -202,10 +201,6 @@ protected function _getModifiedOrders($magentoStoreId) } $orderJson = $this->GeneratePOSTPayload($order, $mailchimpStoreId, $magentoStoreId, true, $isSynced); - if ($this->modifiedOrder) { - $order->save(); - $this->modifiedOrder = false; - } if ($orderJson!==false) { if (!empty($orderJson)) { $this->_helper->modifyCounter(\Ebizmarts\MailChimp\Helper\Data::ORD_MOD); @@ -284,10 +279,6 @@ protected function _getNewOrders($magentoStoreId) } } $orderJson = $this->GeneratePOSTPayload($order, $mailchimpStoreId, $magentoStoreId, false, $isSynced); - if ($this->modifiedOrder) { - $order->save(); - $this->modifiedOrder = false; - } if ($orderJson!==false) { if (!empty($orderJson)) { $this->_helper->modifyCounter(\Ebizmarts\MailChimp\Helper\Data::ORD_NEW); @@ -334,11 +325,10 @@ protected function GeneratePOSTPayload(\Magento\Sales\Model\Order $order, $mailc if ($order->getMailchimpCampaignId()) { $data['campaign_id'] = $order->getMailchimpCampaignId(); } elseif ($isSynced) { - if ($campaignId = $this->getCampaign($magentoStoreId, $order->getCustomerEmail())) { + if (!$isModifiedOrder && $campaignId = $this->getCampaign($magentoStoreId, $order->getCustomerEmail())) { $data['campaign_id'] = $campaignId; $order->setMailchimpCampaignId($campaignId); $order->setMailchimpFlag(1); - $this->modifiedOrder = true; } }