Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Skill Bindable Option #777

Open
RAYCAL2000 opened this issue May 29, 2024 · 3 comments
Open

[Enhancement] Skill Bindable Option #777

RAYCAL2000 opened this issue May 29, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@RAYCAL2000
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some skills we have are passive and trigger on dealing damage, running, etc. Players are currently able to bind them to their items and it causes headaches as they can activate skills more times then they should be able to.

Describe the solution you'd like
Add an option into each individual skill that either marks them passive and prevents them from being binded or just a boolean that allows or prevents a skill from being able to be binded.

Describe alternatives you've considered
There are currently no alternatives that exist to this problem that I am aware of.

Additional context
None, just let me know if you have any additional questions!

@RAYCAL2000 RAYCAL2000 added the enhancement New feature or request label May 29, 2024
@Travja
Copy link
Contributor

Travja commented May 29, 2024

This is mostly in relation to #776? I can see them binding passives to armor and wearing it to get the effects on a different class being a problem. Binding passives from your active class shouldn't be an issue though?

@RAYCAL2000
Copy link
Contributor Author

RAYCAL2000 commented May 30, 2024

This is mostly in relation to #776? I can see them binding passives to armor and wearing it to get the effects on a different class being a problem. Binding passives from your active class shouldn't be an issue though?

If you have a passive such as dealing damage giving you health back, if they bind that to a weapon it doubles up the effect of a skill.

Also in regards to #776 even if they don't have skills bound they still activate when they shouldn't when a change class occurs. Passives still persist basically.

@Travja
Copy link
Contributor

Travja commented Nov 16, 2024

Passives shouldn't persist across changing classes at this point, but there is still likely a need to prevent players from binding some skills to items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants