Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Adding Defense_VANILLA_GENERIC #285

Open
MaksyKun opened this issue Jan 21, 2025 · 0 comments
Open

[Enhancement] Adding Defense_VANILLA_GENERIC #285

MaksyKun opened this issue Jan 21, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@MaksyKun
Copy link
Contributor

MaksyKun commented Jan 21, 2025

Is your feature request related to a problem? Please describe.
The problem Im facing is the full customized combat system which manipulates "armor"-behaviour as defense types in total. I haven't found a way to disable this and use default armor attributes.

Describe the solution you'd like
Therefore, my idea is to implement DEFENSE_VANILLA_GENERIC as a defense type equal to the vanilla generic damage type.

Describe alternatives you've considered
My alternative would have been to use the physical defense type as armor attribute, but this is tricky and inconsistent with our existent vanilla items which have simple modified attributes.

Additional context
In case anyone wants to implement it, feel free. Otherwise I'd give it a try on myself. You can assign me if needed.

@MaksyKun MaksyKun added the enhancement New feature or request label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant