Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 compatibility #20

Closed
m-lagiewka opened this issue May 19, 2023 · 2 comments
Closed

PHP 8.1 compatibility #20

m-lagiewka opened this issue May 19, 2023 · 2 comments

Comments

@m-lagiewka
Copy link

hi,
just now i was doing an upgrade to 2.4.6 & php8.1 and got the following warnings
Warning: Private methods cannot be final as they are never overridden by other classes in /var/www/html/vendor/magefan/module-community/Model/Section.php on line 144

Warning: Private methods cannot be final as they are never overridden by other classes in /var/www/html/vendor/magefan/module-community/Model/Section/Info.php on line 83

Nothing urgent, but ugly. Could you possibly do something about it? :)

@magefan
Copy link
Owner

magefan commented May 19, 2023

@m-lagiewka , thank you for your report. Think you get this error because of using some old version of magefan/module-community. To fix this issue please update the module to the latest version.

@magefan magefan closed this as completed May 19, 2023
@m-lagiewka
Copy link
Author

thanks for immediate response, you are right. for some reason wysiwyg advanced module with deps >=2.1.11 pulled exactly this version instead of the newest. could be cache. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants