Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse general/enabled - Why? #11

Closed
lsv opened this issue Apr 23, 2021 · 3 comments
Closed

Reverse general/enabled - Why? #11

lsv opened this issue Apr 23, 2021 · 3 comments

Comments

@lsv
Copy link

lsv commented Apr 23, 2021

https://github.com/magefan/module-community/blob/master/Cron/Sections.php#L57

Just why?

@magefan
Copy link
Owner

magefan commented Apr 23, 2021

it's a string "general/enabled" we don`t want it to be searchable in the code.

@magefan magefan closed this as completed Apr 23, 2021
@lsv
Copy link
Author

lsv commented Apr 23, 2021

I know - but why dont you want it to be searchable? - my antivirus is actually giving me a red flag

@magefan
Copy link
Owner

magefan commented Apr 23, 2021

PHP is an open code, so actually anyone can see and change your code. Some unscrupulous developers and store owners can steal modules (and they do) use the modules without the purchase or even rename "Magefan" with their vendor name and sell as its own extension. We have numerous cases of this. Even our free extensions like Magento 2 Blog have been stolen, renamed, and sold on other websites. So we adding pain in the ass for them (sorry for the rudeness). strrev is simple and helps us in this fight.

As for antivirus, yes, some of them can show notices, but if you'll check those warnings, you'll see that our Modules are safe to use. Please contact us via email [email protected] if you have any other questions or concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants