Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider building the fs layers on the broker instead of having the worker do it. #459

Open
nfachan opened this issue Feb 3, 2025 · 0 comments

Comments

@nfachan
Copy link
Collaborator

nfachan commented Feb 3, 2025

We're in a bit of a weird place right now.

The broker holds a reference count on all digests used by a job. This means it needs to read manifests to see what digests they use. It does this work, and caches the result.

Then, it sends jobs to workers. The workers then read the manifests and build their own fs layers, hopefully finding cached versions. This seems like a kind of weird and arbitrary separation of the two.

Instead, one could imagine the broker building the fs layers and sharing them with the workers. This way the fs layers would only be built once (not on every broker), and could be cached across broker invocations.

Alternatively, if we don't want the broker to actually be doing this work, we could have a mechanism where it could ask a single worker to read the manifests and build the fs layers, then share the result back. Then, the worker could re-distribute that data with the other workers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant