Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change genre abbreviations to full names. #136

Open
madmaxoft opened this issue May 31, 2018 · 3 comments
Open

Change genre abbreviations to full names. #136

madmaxoft opened this issue May 31, 2018 · 3 comments

Comments

@madmaxoft
Copy link
Owner

The abbreviations should only stay in the default template filters' names; everywhere else should use full genre names, to avoid confusion.

@madmaxoft
Copy link
Owner Author

@kalich5 Thoughts on this? Good or bad?

@madmaxoft
Copy link
Owner Author

Migration:

  • Existing song metadata can be auto-upgraded using a DB version upgrade script
  • Existing template filters can be auto-upgraded using a DB version upgrade script
  • When importing template filters from XML, a special "upgrade" can be added

Points to consider:

  • Abbreviations can be tricky (RU vs RB, SA vs SB vs SL)
  • Abbreviations take less UI space (song property columns)
  • Abbreviations are fixed; full name can be left freely editable for new genres.

@madmaxoft
Copy link
Owner Author

Option: Keep the genres stored as abbreviations, but translate them in UI to full names - in the song property editor and template filter editor. This way we can translate the full names, yet keep the filters simple and language-independent.
Keep the genre field freely editable, an unknown value will not be translated; if a new known genre is added later on, it can translate these values in DB upgrade scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant