Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace static factory methods called new with create #28

Open
maciej-sz opened this issue Feb 2, 2025 · 0 comments
Open

Replace static factory methods called new with create #28

maciej-sz opened this issue Feb 2, 2025 · 0 comments
Labels
enhancement v3 Changes planned for version 3

Comments

@maciej-sz
Copy link
Owner

maciej-sz commented Feb 2, 2025 •
edited
Loading

The public static function new() methods is confusing.
Plus it was breaking the ability to run the lib in older PHP versions, since new keyword was reserved.

The goal of this task is to replace all the factory methods called new and rename them to create.
@maciej-sz maciej-sz added enhancement v3 Changes planned for version 3 labels Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement v3 Changes planned for version 3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maciej-sz