Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to change of free_symbols in sympy 1.2 #87

Open
goerz opened this issue Oct 14, 2018 · 0 comments
Open

Adapt to change of free_symbols in sympy 1.2 #87

goerz opened this issue Oct 14, 2018 · 0 comments

Comments

@goerz
Copy link
Member

goerz commented Oct 14, 2018

SymPy made a backwards-incompatible change to how free_symbols works for Indexed expressions. See sympy/sympy#13360.

Currently, on Travis and AppVeyor, we enforce SymPy < 1.2 to avoid this problem. We should remove this restriction by investigating what the consequences SymPy's change are for QNET, and whether we need additional tests. Anything that relies on free_symbols needs to be checked carefully -- especially derivatives.

Tests should be written in such a way that they pass both for SymPy < 1.2 and SymPy >= 1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant