Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenXR releases to CI #39

Open
m4ym4y opened this issue Feb 27, 2025 · 4 comments
Open

Add OpenXR releases to CI #39

m4ym4y opened this issue Feb 27, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@m4ym4y
Copy link
Owner

m4ym4y commented Feb 27, 2025

Builds are now created on release thanks to @cassidyjames work! I'd like to add builds for OpenXR releases automatically too, which should be possible through the same build commands but with the --use-vr flag I think!

@m4ym4y m4ym4y added the enhancement New feature or request label Feb 27, 2025
@m4ym4y
Copy link
Owner Author

m4ym4y commented Feb 27, 2025

Been messing around with this locally but I haven't been able to produce a VR build by modifying command line args or env vars. I tried --xr-mode on and --feature xr . I guess if all else fails it would be possible to just modify the project.godot for the build command with sed -i

@dsnopek
Copy link
Contributor

dsnopek commented Feb 27, 2025

It's possible to make special export presets that have XR enabled. So, for example, you could have two Windows exports, one with XR enabled, and the other without.

It'd work basically the same as how I setup the project settings that are specific to the Meta Quest export in #37: you'd make a "Windows (XR)" export preset, add a custom feature tag to it (for example, "xr") and then in project settings make an "openxr/enabled.xr" override to turn it on only for that feature tag.

Then from the command like you could do godot --export-release "Windows (XR)" to make the XR version.

Please let me know if you'd like me to make a PR for that!

Alternatively, you could have a single export, but a button in the game that would restart the game in XR mode (adding the --xr-mode on CLI option you mentioned above). That could be somewhat easier for users, not having to download two versions? It's up to you which approach you prefer - since you already have the two versions, I assume that'll be your preference

@m4ym4y
Copy link
Owner Author

m4ym4y commented Mar 1, 2025

Thank you! I'll give it a shot and ask u if i need help figuring it out.

@cassidyjames btw it looks like there's an issue with the CI job for backing a release -- https://github.com/m4ym4y/museum-of-all-things/actions/runs/13564158453/job/37913484993 Do you know what's up w this error?

@cassidyjames
Copy link
Contributor

@m4ym4y hm, I'll look into it; for now I've filed an issue here: #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants