Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default button label for Confirm Dialog not displaying correctly. #122

Open
ywongweb opened this issue Jul 1, 2015 · 4 comments
Open

Default button label for Confirm Dialog not displaying correctly. #122

ywongweb opened this issue Jul 1, 2015 · 4 comments

Comments

@ywongweb
Copy link

ywongweb commented Jul 1, 2015

The default text for confirm dialog buttons are showing DIALOG_YES/DIALOG_NO instead of Yes/No. This problem first occurred in v5.1.0

http://codepen.io/anon/pen/KpQgEj

@m-e-conroy
Copy link
Owner

Try using Angular-Bootstrap 0.12 or 0.13, the pen you posted is using 0.11. Let me know if that fixes the problem - I haven't encountered this and I use the service on a daily basis. My current project uses Angular-Bootstrap 0.13.0 and the Angular-Dialog-Service 5.2.8.

@ywongweb
Copy link
Author

I've made a plnkr with 0.13 and 5.2.8, it's still doing the same thing.

Changing the language to Spanish works as expected.
Changing Angular-Dialog-Service back to v5.0.0 also works.

http://plnkr.co/edit/RLC1g0UGp9INxp4uHTLf?p=preview

@cmcnamara87
Copy link

Having the same problem as @ywongweb

@vmlf01
Copy link

vmlf01 commented Jan 13, 2016

I had to include the both 'dialogs.main' and 'dialogs.default-translations' to my module dependencies for it to pick up the translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants