Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Omniauth user reset password #335

Closed
ianchen06 opened this issue Aug 13, 2015 · 1 comment
Closed

Allow Omniauth user reset password #335

ianchen06 opened this issue Aug 13, 2015 · 1 comment

Comments

@ianchen06
Copy link

Hi there thanks for this great gem, I currently have a working system with both Devise email&password authentication as well as Omniauth-Facebook authentication.

I'm aware that currently this gem does not allow Omniauth sign up users to reset their passwords, is this feature on the roadmap? Or is there any difficulties with implementing this feature? I'm willing to send in a PR for this feature.

Thanks,

@booleanbetrayal
Copy link
Collaborator

This feature isn't currently on the roadmap, but a few users have said they'd be interested in something along those lines. Today, you're fixed to a specific provider (email, fb, google, etc). So if you're user is registered using omniauth, devise_token_auth won't even attempt to do anything with email credentials, they aren't tied to your provider.

In essence, whatever implementation is made would have to be savvy enough to allow for any and all providers, as it seems somewhat arbitrary to allow FB and email, but not FB and Google, etc. It starts getting tricky as to how you want to handle those sort of provider validations, etc.

Going to close this ticket and direct you to #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants