Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add 3 missing props to React documentation #132

Open
niko7o opened this issue Mar 31, 2020 · 2 comments
Open

enhancement: add 3 missing props to React documentation #132

niko7o opened this issue Mar 31, 2020 · 2 comments

Comments

@niko7o
Copy link

niko7o commented Mar 31, 2020

💅 Details

While implementing this slider at the office, I was navigating around the source files and saw three new props that weren't in the documentation & I was able to use ⚡️

I tried to open a branch for the pull request but it seems I wasn't allowed at this stage 😢

Would love to contribute! This would be my first contribution on Github Issues.

These props are:

  • draggable
  • dragStart
  • dragEnd

🔍 Suggested changes

Add these props to the README so that newcomers to the library may find a use for them 💃

Screenshot

The complete documentation proposal would look like this:

Screenshot 2020-03-31 at 23 08 21

@niko7o niko7o changed the title Missing props for React documentation Suggestion: add 3 missing props to React documentation Mar 31, 2020
@niko7o niko7o changed the title Suggestion: add 3 missing props to React documentation enhancement: add 3 missing props to React documentation Mar 31, 2020
@niko7o
Copy link
Author

niko7o commented Mar 31, 2020

Let me know if you see any possible improvements or want to suggest changes! 🥇 i'm open to anything.

@lyfeyaj
Copy link
Owner

lyfeyaj commented May 12, 2020

PR is welcome 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants