Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that scripts has a least 1 action #4

Closed
emilingerslev opened this issue Oct 2, 2018 · 3 comments
Closed

Validate that scripts has a least 1 action #4

emilingerslev opened this issue Oct 2, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@emilingerslev
Copy link
Contributor

It does not make sense that scripts do not have actions, so fail running the script if so. Plus maybe consider a warning when doing an overall validation.
@emilingerslev
Copy link
Contributor Author

Related to #3

@emilingerslev emilingerslev added the enhancement New feature or request label Oct 2, 2018
@Crevil
Copy link
Contributor

Crevil commented Dec 17, 2018

Related to #6 as well.

michaelbui99 added a commit to michaelbui99/shuttle that referenced this issue Nov 18, 2022
@michaelbui99
# This is a combination of 6 commits.
f84a8be 
# This is the 1st commit message:

Added config command to output Shuttle version, Environment Variables and Plan

# This is the commit message lunarway#2:

Removed unnecessary loop

Signed-off-by: Michael Bui <[email protected]>

# This is the commit message lunarway#3:

Display plan + head for git plans

Signed-off-by: Michael Bui <[email protected]>

# This is the commit message lunarway#4:

Added test cases, use RunE instead of Run, move Plan output above Environment output

Signed-off-by: Michael Bui <[email protected]>

# This is the commit message lunarway#5:

Update test case name

Signed-off-by: Michael Bui <[email protected]>

# This is the commit message lunarway#6:

Removed unnecessary loop
@kjuulh
Copy link
Contributor

kjuulh commented Oct 20, 2023

Because of the golang actions, this is actually a legal approach now. Which invalidates this issue

@kjuulh kjuulh closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emilingerslev @Crevil @kjuulh