Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow putsing emails in the DevAdapter #14

Closed
paulcsmith opened this issue Jun 18, 2018 · 2 comments · Fixed by #15
Closed

Allow putsing emails in the DevAdapter #14

paulcsmith opened this issue Jun 18, 2018 · 2 comments · Fixed by #15
Labels
help wanted Extra attention is needed

Comments

@paulcsmith
Copy link
Member

paulcsmith commented Jun 18, 2018

#3 (comment)

  • Add an optional print_emails option to the DevAdapter
  • Default it to false
Carbon::DevAdapter.new(print_emails: true)

Will puts the email when delivering. This would go in this method:

def deliver_now(email : Carbon::Email)
@@delivered_emails << email
end

@paulcsmith paulcsmith added the help wanted Extra attention is needed label Jun 18, 2018
@camuthig
Copy link
Contributor

camuthig commented Aug 3, 2018

I'm looking to experiment with Crystal some, and am interested in helping out with this ticket. Is there any particular format you think would be best for the output?

@paulcsmith
Copy link
Member Author

@camuthig That would be fantastic! I can't think of a particular format, but maybe something like this?

To: ...
From: ...
Subject: ...
Headers: ...
Text Body: ...
HTML Body: ...

I think those keys can be colorized as green so it's easier to differentiate between key value. You can use the colorize module built in to Crystal: https://crystal-lang.org/api/0.25.1/Colorize.html

LMK if you have any other questions. I'm happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants