TagsSpanTagger: how to support in play 2.7

[pjfanning]

This class depends on being able to iterate over the request tags.

Play 2.7 removes the ability to do this. request.tags called request.attrs.get(RequestAttrKey.Tags) (play 2.6) but RequestAttrKey.Tags is no longer supported in play 2.7. The 2.6 deprecation warning said to use request.attrs directly.

request.attrs does not return a Map. Instead, it returns a TypedMap that does not expose an iterator. This means you can only access attrs that you know the key name of.

[jjudd]

Thanks for doing this! I've pinged the team internally. A group is working on migrating to Play 2.7 and will likely have time to look at this in the next week.

[jjudd]

cc @sriraamas

[tmccombs]

hmm, @pjfanning do you have a use case for TagsSpanTagger? I don't think that we (Lucid Software) currently use this ourselves. My first impression is to just remove TagsSpanTagger or replace it with an AttributeSpanTagger that takes a TypedKey.

[pjfanning]

@tmccombs I don't use it either - I was just trying to retain support in case other people used it

[Zeimyth]

Should be fixed by #5, though it might be worth publishing an actual Play 2.7 version of this library and removing the TagsSpanTagger.