Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two EmbeddingWrappers found for optimization #20

Open
irowberry opened this issue Sep 20, 2023 · 3 comments
Open

Two EmbeddingWrappers found for optimization #20

irowberry opened this issue Sep 20, 2023 · 3 comments

Comments

@irowberry
Copy link

I create an EmbeddingWrapper instance once within my model's initialize method, however when I print out the module instances in the get_finetune_parameters function, I have two showing up.

@lucidrains
Copy link
Owner

are you also using the OpenClipEmbeddingWrapper too? you should be only using one or the other, depending on how you are wiring it up

@irowberry
Copy link
Author

No, I'm only using the EmbeddingWrapper.

@lucidrains
Copy link
Owner

ah i see, it is probably not correct then

no worries, i'll look early next month. valiant effort! what you are messing around with is top of the line research; good experience if you are looking to go towards the graduate school route :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants