Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger device crashes when using transfer schema v2 or v3 #3

Open
brunodb3 opened this issue Sep 7, 2021 · 2 comments
Open

Ledger device crashes when using transfer schema v2 or v3 #3

brunodb3 opened this issue Sep 7, 2021 · 2 comments

Comments

@brunodb3
Copy link

brunodb3 commented Sep 7, 2021

While implementing ledger support for the official LTO Wallet UI, I came across an issue where the ledger device just stops responding and reboots if I send a transaction using the v2 or v3 schema. Even using the proper v1 schema doesn't work, I had to modify it slightly in order to work correctly. So far I only tested with transfer transactions, not sure if it happens with other types.

We want to have latest schema support for ledger transactions, while also supporting older schemas. So v1, v2 and v3 should all work.

@iicc1
Copy link
Collaborator

iicc1 commented Sep 13, 2021

Hello,
Only the v1 schema is currently supported. Also, the payload needs to be modified before sending the data to the Ledger device. You can check how the payload is constructed with the script located here: https://github.com/Stakely/lto-network-ledger-wallet-ui/blob/master/scripts/transactions.js

Also, there is additional data sent to the device which includes the network id and the BIP path: https://github.com/Stakely/lto-network-ledger-wallet-ui/blob/master/pages/index.vue#L527

@brunodb3
Copy link
Author

brunodb3 commented Sep 13, 2021

Thank you for the response. Indeed I saw the payload is slightly different on the device, and modified my code accordingly. We want to support later versions though, so the code needs to be changed. I will mess around with this repository to see what can be done, maybe I'll create a PR with support for v2-v3 😄 Any help/feedback would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants