Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SSL Encryption #101

Closed
andrewmunro opened this issue Mar 7, 2018 · 6 comments
Closed

Support SSL Encryption #101

andrewmunro opened this issue Mar 7, 2018 · 6 comments
Labels

Comments

@andrewmunro
Copy link

Hi, looking through the library it looks like it doesn't support encrypted traffic to kafka:

https://docs.confluent.io/current/kafka/authentication_ssl.html

Would this be difficult to implement?

@db7
Copy link
Collaborator

db7 commented Mar 8, 2018

Goka does not implement the communication with Kafka. For that we employ existing libraries. By default, Goka uses sarama, which is pure Go and does support SSL connections.

As an alternative, you may also use confluent-kafka-go, which uses librdkafka underneath and should support virtually everything you'd need. Although our wrapper around confluent's library isn't complete yet, it shouldn't be too hard to finish it.

@db7 db7 added the question label Mar 8, 2018
@andrewmunro
Copy link
Author

I see that it's possible with sarama, but the question was more around whether goka will let me configure the TLS options passed to sarama?

It may be possible using goka.WithProducerBuilder() and goka.WithConsumerBuilder(), I'll have a play when I have time. If I get a decent example I'll post back here.

@db7
Copy link
Collaborator

db7 commented Mar 9, 2018

Yes, you can configure sarama with the builders. Check this snippet for an example.

@andrewmunro
Copy link
Author

Perfect this is exactly what I needed. Thanks @db7

@Larleyt
Copy link

Larleyt commented Dec 23, 2024

Hello,

I've opened an issue related to Sarama's SSL inside goka, could you please elaborate on that? @db7

The link you've provided contains outdated docs – there's no way to configure anything but Sarama for goka now. And it simply doesn't work with SSL enabled, while works locally in plaintext (please, look at the issue for details).

@db7
Copy link
Collaborator

db7 commented Dec 23, 2024

@frairon ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants