Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(return type):Update render-task-result in methods.ts #1376

Closed
wants to merge 1 commit into from
Closed

fix(return type):Update render-task-result in methods.ts #1376

wants to merge 1 commit into from

Conversation

yogendrasgautam
Copy link

@yogendrasgautam yogendrasgautam commented Oct 12, 2023 •
edited
Loading

Fix for #1369 - Update render-task-result in methods.ts to return Blob result

👋👋 Thank you for contributing to Looker sdk-codegen (⚡️🍣)

  • 👉 While using render_task_result call to render the pdf result for dashboard. it returns string blob which is not accepted as parameter to URL.createObjectUrl(). URL.createObjectUrl() function accepts the value in Blob format

Developer Checklist ℹ️

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #1375 🦕

@yogendrasgautam
Update render-task-result in methods.ts
ec814b6 
Fix for looker-open-source#1369 - Update render-task-result in methods.ts to return Blob result
@google-cla
Copy link

google-cla bot commented Oct 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@yogendrasgautam yogendrasgautam requested a review from a team as a code owner March 12, 2024 22:37
@jeremytchang
Copy link
Collaborator

Based on the linked issue, it was not an issue with the code. Also our methods are auto generated and should not be manually changed.

Closing for now, feel free to re-open if you want to update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

render_task_results in typescript Looker40SDK returns string
2 participants
@yogendrasgautam @jeremytchang