diff --git a/__tests__/dummy-projects/33-w1-tests/01-good.view.lkml b/__tests__/dummy-projects/.33-w1-tests/01-good.view.lkml similarity index 100% rename from __tests__/dummy-projects/33-w1-tests/01-good.view.lkml rename to __tests__/dummy-projects/.33-w1-tests/01-good.view.lkml diff --git a/__tests__/dummy-projects/33-w1-tests/02-bad.view.lkml b/__tests__/dummy-projects/.33-w1-tests/02-bad.view.lkml similarity index 100% rename from __tests__/dummy-projects/33-w1-tests/02-bad.view.lkml rename to __tests__/dummy-projects/.33-w1-tests/02-bad.view.lkml diff --git a/__tests__/dummy-projects/33-w1-tests/03-old-cc-indented-nospace.view.lkml b/__tests__/dummy-projects/.33-w1-tests/03-old-cc-indented-nospace.view.lkml similarity index 100% rename from __tests__/dummy-projects/33-w1-tests/03-old-cc-indented-nospace.view.lkml rename to __tests__/dummy-projects/.33-w1-tests/03-old-cc-indented-nospace.view.lkml diff --git a/__tests__/dummy-projects/33-w1-tests/04-new-cc-indented-space.view.lkml b/__tests__/dummy-projects/.33-w1-tests/04-new-cc-indented-space.view.lkml similarity index 100% rename from __tests__/dummy-projects/33-w1-tests/04-new-cc-indented-space.view.lkml rename to __tests__/dummy-projects/.33-w1-tests/04-new-cc-indented-space.view.lkml diff --git a/__tests__/dummy-projects/33-w1-tests/index.test.js b/__tests__/dummy-projects/.33-w1-tests/index.test.js.txt similarity index 100% rename from __tests__/dummy-projects/33-w1-tests/index.test.js rename to __tests__/dummy-projects/.33-w1-tests/index.test.js.txt diff --git a/__tests__/dummy-projects/33-w1-tests/manifest.lkml b/__tests__/dummy-projects/.33-w1-tests/manifest.lkml similarity index 100% rename from __tests__/dummy-projects/33-w1-tests/manifest.lkml rename to __tests__/dummy-projects/.33-w1-tests/manifest.lkml diff --git a/__tests__/dummy-projects/33-w1-tests/my_model.model.lkml b/__tests__/dummy-projects/.33-w1-tests/my_model.model.lkml similarity index 100% rename from __tests__/dummy-projects/33-w1-tests/my_model.model.lkml rename to __tests__/dummy-projects/.33-w1-tests/my_model.model.lkml diff --git a/docs/release-notes/v3.md b/docs/release-notes/v3.md index 564eb12..c57b4ab 100644 --- a/docs/release-notes/v3.md +++ b/docs/release-notes/v3.md @@ -100,4 +100,5 @@ LookML Dashboards are now supported. This functionality is disabled by default. Patches: - v3.4.1 - Dependency updates in LAMS for jsonpath-plus. Dependency updates in Rule Sandbox for webpack and sub-dependencies. -- v3.4.2 - v3.4.0 had introduced a change in behavior at the intersection of conditional comments and whitespace rule W1. Since whitespace behavior for conditional comments had not been formally defined or desrcribed, this release defines the conditional comment whitespace handling going forward, primarily chosen to mirror the in-Looker IDE behavior when a block is commented via the Ctrl+/ shortcut. \ No newline at end of file +- v3.4.2 - v3.4.0 had introduced a change in behavior at the intersection of conditional comments and whitespace rule W1. Since whitespace behavior for conditional comments had not been formally defined or desrcribed, this release defines the conditional comment whitespace handling going forward, primarily chosen to mirror the in-Looker IDE behavior when a block is commented via the Ctrl+/ shortcut. +- v3.4.3 - Reverts v3.4.2, leaving whitespace handling as-is. New whitespace handling will be introduced as a breaking change in v4. \ No newline at end of file diff --git a/npm-shrinkwrap.dev.json b/npm-shrinkwrap.dev.json index ee3bcde..a3b6ff6 100644 --- a/npm-shrinkwrap.dev.json +++ b/npm-shrinkwrap.dev.json @@ -1,19 +1,19 @@ { "name": "@looker/look-at-me-sideways", - "version": "3.4.2", + "version": "3.4.3", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@looker/look-at-me-sideways", - "version": "3.4.2", + "version": "3.4.3", "license": "MIT", "dependencies": { "dot": "^1.1.3", "fromentries": "^1.3.2", "jsonpath-plus": "^10.2.0", "liyad": "^0.2.4", - "lookml-parser": "^6.11.0", + "lookml-parser": "^6.10.0", "minimist": "^1.2.6", "require-from-string": "^2.0.2" }, @@ -3862,9 +3862,9 @@ "dev": true }, "node_modules/lookml-parser": { - "version": "6.11.0", - "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.11.0.tgz", - "integrity": "sha512-NIw+ViMopuuuBfP8XHpzJl57UYGMfuQ4FQp2vdAbAIVUzYlfIex19/6ZAwOOPRf3O7uOm+CVF92zw9Hkfk9yOA==", + "version": "6.10.0", + "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.10.0.tgz", + "integrity": "sha512-eA8+zt7wUKXnkx+7M86Z7mRqta3+TZhMkYTVmyMau+F7a5SzjMhsXzQqWmQgyZmD/iRElWyb+6LQ2b/5SSwBaQ==", "dependencies": { "bluebird": "^3.5.1", "glob": "^7.1.2", @@ -8052,9 +8052,9 @@ "dev": true }, "lookml-parser": { - "version": "6.11.0", - "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.11.0.tgz", - "integrity": "sha512-NIw+ViMopuuuBfP8XHpzJl57UYGMfuQ4FQp2vdAbAIVUzYlfIex19/6ZAwOOPRf3O7uOm+CVF92zw9Hkfk9yOA==", + "version": "6.10.0", + "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.10.0.tgz", + "integrity": "sha512-eA8+zt7wUKXnkx+7M86Z7mRqta3+TZhMkYTVmyMau+F7a5SzjMhsXzQqWmQgyZmD/iRElWyb+6LQ2b/5SSwBaQ==", "requires": { "bluebird": "^3.5.1", "glob": "^7.1.2", diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json index ee3bcde..a3b6ff6 100644 --- a/npm-shrinkwrap.json +++ b/npm-shrinkwrap.json @@ -1,19 +1,19 @@ { "name": "@looker/look-at-me-sideways", - "version": "3.4.2", + "version": "3.4.3", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@looker/look-at-me-sideways", - "version": "3.4.2", + "version": "3.4.3", "license": "MIT", "dependencies": { "dot": "^1.1.3", "fromentries": "^1.3.2", "jsonpath-plus": "^10.2.0", "liyad": "^0.2.4", - "lookml-parser": "^6.11.0", + "lookml-parser": "^6.10.0", "minimist": "^1.2.6", "require-from-string": "^2.0.2" }, @@ -3862,9 +3862,9 @@ "dev": true }, "node_modules/lookml-parser": { - "version": "6.11.0", - "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.11.0.tgz", - "integrity": "sha512-NIw+ViMopuuuBfP8XHpzJl57UYGMfuQ4FQp2vdAbAIVUzYlfIex19/6ZAwOOPRf3O7uOm+CVF92zw9Hkfk9yOA==", + "version": "6.10.0", + "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.10.0.tgz", + "integrity": "sha512-eA8+zt7wUKXnkx+7M86Z7mRqta3+TZhMkYTVmyMau+F7a5SzjMhsXzQqWmQgyZmD/iRElWyb+6LQ2b/5SSwBaQ==", "dependencies": { "bluebird": "^3.5.1", "glob": "^7.1.2", @@ -8052,9 +8052,9 @@ "dev": true }, "lookml-parser": { - "version": "6.11.0", - "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.11.0.tgz", - "integrity": "sha512-NIw+ViMopuuuBfP8XHpzJl57UYGMfuQ4FQp2vdAbAIVUzYlfIex19/6ZAwOOPRf3O7uOm+CVF92zw9Hkfk9yOA==", + "version": "6.10.0", + "resolved": "https://registry.npmjs.org/lookml-parser/-/lookml-parser-6.10.0.tgz", + "integrity": "sha512-eA8+zt7wUKXnkx+7M86Z7mRqta3+TZhMkYTVmyMau+F7a5SzjMhsXzQqWmQgyZmD/iRElWyb+6LQ2b/5SSwBaQ==", "requires": { "bluebird": "^3.5.1", "glob": "^7.1.2", diff --git a/package.json b/package.json index 1cc81b8..91f606d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@looker/look-at-me-sideways", - "version": "3.4.2", + "version": "3.4.3", "description": "A judgmental little LookML linter >_>", "main": "index.js", "directories": { @@ -39,7 +39,7 @@ "fromentries": "^1.3.2", "jsonpath-plus": "^10.2.0", "liyad": "^0.2.4", - "lookml-parser": "^6.11.0", + "lookml-parser": "^6.10.0", "minimist": "^1.2.6", "require-from-string": "^2.0.2" },