Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - setting to treat dimension groups as one field #19

Open
moseleyi opened this issue Feb 26, 2020 · 0 comments
Open

Feature request - setting to treat dimension groups as one field #19

moseleyi opened this issue Feb 26, 2020 · 0 comments

Comments

@moseleyi
Copy link

dimension_group: created_at{
    type: time
    timeframes: [ raw, time, date, week, month, quarter, year, day_of_week ]
    sql: ${TABLE}.created_at;;
  }

Sometimes only one of the timeframes might be used across the explores but, as it's in my case, we prefer to keep the timeframes list pretty standardised.

At the moment Henry will treat each timeframe as a separate field, which could give us a wrong impression that the field itself is not used by any timeframe.

+---------+-----------------+----------------+------------------------------------+
| Model   | Explore         | Unused Joins   | Unused Fields                      |
|---------+-----------------+----------------+------------------------------------|
| model   | explore         |                | explore.created_at_day_of_week     |
|         |                 |                | explore.created_at_month           |
|         |                 |                | explore.created_at_quarter         |
|         |                 |                | explore.created_at_time            |
|         |                 |                | explore.created_at_week            |
|         |                 |                | explore.created_at_year            |

Perhaps if I remember all the timeframes we use in our data model, I could quickly decide whether anything is missing. Problem is that even if we want to standardise something, doesn't mean that ocassionally timeframes might differ.

It would be great if we could change the way Henry treats those fields. In this case created_at would be one field and treated as used if at least one of its timeframes is used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant