From 9a7db4add4f92f037037c19a79d060da64d25db1 Mon Sep 17 00:00:00 2001
From: Jeremy Cohen <jeremy.cohen@imperial.ac.uk>
Date: Tue, 1 Jun 2021 18:21:45 +0100
Subject: [PATCH] Fixed some compile warnings - use of deprecated Boolean
 constructor, type casts, POM encoding

---
 pom.xml                                                      | 3 +++
 .../libhpc2/schemaservice/SchemaProcessorServlet.java        | 1 +
 .../schemaservice/web/dao/impl/JdbcProfileDaoImpl.java       | 5 +----
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/pom.xml b/pom.xml
index 428ff58..192bc50 100644
--- a/pom.xml
+++ b/pom.xml
@@ -7,6 +7,9 @@
 	<version>0.0.1-SNAPSHOT</version>
 	<name>TemPSS Maven Webapp</name>
 	<url>http://maven.apache.org</url>
+	<properties>
+		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+	</properties>
 	<dependencies>
 		<dependency>
 			<groupId>junit</groupId>
diff --git a/src/main/java/uk/ac/imperial/libhpc2/schemaservice/SchemaProcessorServlet.java b/src/main/java/uk/ac/imperial/libhpc2/schemaservice/SchemaProcessorServlet.java
index 1139dde..18a3634 100644
--- a/src/main/java/uk/ac/imperial/libhpc2/schemaservice/SchemaProcessorServlet.java
+++ b/src/main/java/uk/ac/imperial/libhpc2/schemaservice/SchemaProcessorServlet.java
@@ -162,6 +162,7 @@ public void doGet(HttpServletRequest req, HttpServletResponse resp)
      * @throws ServletException if problem
      * @throws IOException if problem
      */
+    @SuppressWarnings("unchecked")
     public void doPost(HttpServletRequest req, HttpServletResponse resp)
             throws ServletException, IOException {
 
diff --git a/src/main/java/uk/ac/imperial/libhpc2/schemaservice/web/dao/impl/JdbcProfileDaoImpl.java b/src/main/java/uk/ac/imperial/libhpc2/schemaservice/web/dao/impl/JdbcProfileDaoImpl.java
index 4551840..b767061 100644
--- a/src/main/java/uk/ac/imperial/libhpc2/schemaservice/web/dao/impl/JdbcProfileDaoImpl.java
+++ b/src/main/java/uk/ac/imperial/libhpc2/schemaservice/web/dao/impl/JdbcProfileDaoImpl.java
@@ -49,17 +49,14 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Set;
 
 import javax.sql.DataSource;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.jdbc.core.JdbcTemplate;
 import org.springframework.jdbc.core.simple.SimpleJdbcInsert;
 import org.springframework.security.core.AuthenticationException;
-import org.springframework.stereotype.Repository;
 
 import uk.ac.imperial.libhpc2.schemaservice.web.dao.ProfileDao;
 import uk.ac.imperial.libhpc2.schemaservice.web.db.Profile;
@@ -80,7 +77,7 @@ public void setDataSource(DataSource dataSource) {
 	
 	@Override
 	public int add(Profile pProfile) {
-		boolean pub = new Boolean(pProfile.getPublic());
+		boolean pub = pProfile.getPublic();
 		Map<String,String> rowParams = new HashMap<String, String>(5);
 		rowParams.put("name", pProfile.getName());
 		rowParams.put("templateId", pProfile.getTemplateId());