Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering the webshop or website URL doesn't work, when starting with a capital H, e.g. Https://meinshop.de #248

Closed
owlRike opened this issue Dec 14, 2020 · 6 comments · Fixed by #249 or #271
Assignees
Labels
enhancement New feature or request

Comments

@owlRike
Copy link

owlRike commented Dec 14, 2020

grafik
grafik

@owlRike owlRike transferred this issue from lokalkauf/lokalkauf-functions Dec 14, 2020
@christianaschoff
Copy link
Contributor

This is common behavior, but I look into it.
At least we should provide an error message

@christianaschoff christianaschoff self-assigned this Dec 15, 2020
@christianaschoff christianaschoff added the enhancement New feature or request label Dec 15, 2020
@christianaschoff christianaschoff linked a pull request Dec 15, 2020 that will close this issue
christianaschoff added a commit that referenced this issue Dec 15, 2020
@Dipanjana1990
Copy link

Dipanjana1990 commented Mar 27, 2021

In the Angebot page the url starting with capital H is not accepted and an error message is displayed but at the same time the same Url is accepted in the Online-Shop Page

image

image

@christianaschoff :Should we not expect serror messages in both the pages as mentioned in Task 244[https://github.com//issues/244]

@christianaschoff
Copy link
Contributor

i am sorry - i overlooked the 2nd dialog :/. will fix this soon - i promise

christianaschoff added a commit that referenced this issue May 2, 2021
@christianaschoff christianaschoff linked a pull request May 2, 2021 that will close this issue
@Dipanjana1990
Copy link

The url starting with capital H is getting accepted in both "Angebot" and "Online-Shop".
@christianaschoff : Please check
image

image

@christianaschoff
Copy link
Contributor

@Dipanjana1990 just checked on lokalkauf-staging and everything seems to work fine with both fields.
Maybe it is a caching-issue… i needed to reload the page without caching to see the changes.
After that everything worked fine after that.

Maybe I got it wrong, but captial h should be accepted as well.

@Dipanjana1990
Copy link

Dipanjana1990 commented May 10, 2021

Now Both field are showing a message when url starts with capital H and both are still getting accepted. I guess this is what is expected.

image
image
image
image

And then Capital H is automaticall changed to "h" in the contact section

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants