Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shops to the list, when there is more than one list #232

Open
owlRike opened this issue Oct 24, 2020 · 7 comments
Open

Adding shops to the list, when there is more than one list #232

owlRike opened this issue Oct 24, 2020 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@owlRike
Copy link

owlRike commented Oct 24, 2020

When clicking the heart to add a shop to a list and you choose the list, which isn't shown at that time, the heart does not turn green.
I think it would be better, if you would switch automatically to the list you have chosen when clicking the heart under a shop. Then the heart turns green and the user knows that it worked.

@owlRike owlRike added the enhancement New feature or request label Oct 24, 2020
@christianaschoff
Copy link
Contributor

Changing the list on the heart will ultimately result in navigating to the "merkliste" overview.
We should discuss that feature on a Tuesday call - might make sense to change the behaviour of merkliste-switching back to where it was before.

@christianaschoff
Copy link
Contributor

I have no memory what we wanted to do here... :D

@owlRike
Copy link
Author

owlRike commented Nov 10, 2020

We wanted to check airbnb & Co. :-) and in the meantime including a confirmation window, when adding a shop to the list, so that users know the shop was added

@christianaschoff christianaschoff added this to the Release-7 milestone Nov 14, 2020
@christianaschoff christianaschoff self-assigned this Nov 14, 2020
@christianaschoff
Copy link
Contributor

right :)

@owlRike
Copy link
Author

owlRike commented Nov 22, 2020

Toast message works perfectly, but the switch between the lists doesn't.
When I add several shops to the list I am not in at that moment, all of the sudden after the second or third shop, the list switches to the other list and shows green hearts at all shops on the other list. But in the top menu it still says I am in the list before (see screen capture video: https://www.dropbox.com/t/eh07iky1dfDkJFm9)
So the menu doesn't work correctly and the switch between the lists, when adding new shops only works randomly.

@christianaschoff
Copy link
Contributor

ups - interesting. Thank you for providing a video. Helps alot :)

@christianaschoff christianaschoff removed their assignment Feb 28, 2021
@christianaschoff
Copy link
Contributor

christianaschoff commented May 18, 2021

@owlRike it took some time, but I guess I figured out what went wrong here.
Please have a look again, ty

Please keep in mind, that it is on security-testing env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants