Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even after deleting the main List( which was made public sometime ago ) the List appears in the 'Öffentliche Merklist'. #223

Open
Dipanjana1990 opened this issue Oct 23, 2020 · 6 comments · May be fixed by #186
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Dipanjana1990
Copy link

Dipanjana1990 commented Oct 23, 2020

Even after deleting the main List( which was made public sometime ago ) the List appears in the 'Öffentliche Merklist'. And on clicking the list no specific list is to be found.

image

@Dipanjana1990 Dipanjana1990 added the bug Something isn't working label Oct 23, 2020
@christianaschoff
Copy link
Contributor

christianaschoff commented Oct 24, 2020

For context: a published list is a copy of the private list that is copied to a public area to prevent mixing up user privileges.
If the private list is deleted, then the public list gets deleted as well, meaning you can not subscribe to it after that even if you have the public link.

If you have a subscription on that list already, that subscription is stored locally and is not tracked by lokalkauf remotely.

The expectation:

  • the "public list" subscription should be removed from all subscribers in case the underlying private list is deleted or unpublished.
  • a sufficient error message should be displayed in case no store can be loaded from the remote source.

@christianaschoff christianaschoff self-assigned this Oct 24, 2020
@christianaschoff christianaschoff added this to the Release-7 milestone Oct 24, 2020
@christianaschoff christianaschoff linked a pull request Oct 24, 2020 that will close this issue
@christianaschoff
Copy link
Contributor

I moved that issue to "to review" column, because I just published an updated version to the internal-testing stage

@Dipanjana1990
Copy link
Author

Dipanjana1990 commented Oct 24, 2020

After making a private list public

image

The list is not appearing in 'öffentliche Merkliste'

image

Expected Result: 'Dipa1' list should appear in both 'Private' and 'öffentliche Merkliste', as I have not stopped sharing it
@christianaschoff : Please let me know if the expected Results are correct or not. I am not changing the status of the ticket as of yet.

@christianaschoff
Copy link
Contributor

@Dipanjana1990 this seems to be the desired behaviour.
If you share your private list, it must not appear in the public list area, because it is still your private list and you have full control over it.

Public lists are only lists, that you subscribe to, not those that you publish.

You can subscribe to your own public list of course if you follow the link that is generated by the share-dialog and "import" it. then it appears in your public list.

Sitenote:
Please do not close an issue at the moment, because we dont know when that feature is published to production and so we might lose track of whats done and what is not. When the epic is merged onto the integration branch, all tickets will be transfered automatically to "ready to test".

@owlRike
Copy link

owlRike commented Nov 22, 2020

I think it's fine, but maybe @Dipanjana1990 might like to check for herself :-)

@Dipanjana1990
Copy link
Author

Tested. Working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants