Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a deployment CI workflow #1059

Open
jondot opened this issue Dec 7, 2024 · 1 comment
Open

add a deployment CI workflow #1059

jondot opened this issue Dec 7, 2024 · 1 comment
Labels

Comments

@jondot
Copy link
Contributor

jondot commented Dec 7, 2024

for each of the deployments, generate the deployment and make sure the app builds.

  1. shuttle: build as a cargo build
  2. docker: build a docker image
@kaplanelad kaplanelad added the ci label Jan 5, 2025
@kaplanelad
Copy link
Contributor

@jondot,

Regarding Shuttle, I suggest we put it on hold until #1120 supports the new platform. If that issue isn’t resolved, we might need to remove Shuttle support in the next release.

For Docker, we're setting up the project (loco new) with the LOCO_DEV_MODE_PATH environment variable. In the Cargo.toml, we are pointing the loco-rs crate to a local path like this:

[workspace.dependencies]
loco-rs = { version = "*", path = "/PATH", default-features = false }

When running docker build as part of the CI process, I encounter the following error:

error: failed to load manifest for dependency `loco-rs`

I can’t run cargo build --release when the path isn’t included in the Dockerfile.

I could inject a COPY instruction to add the local path to the Docker image, that doesn't seem like the best solution.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants