Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an enhanced skill isn't in the dump, it's treated as being 0. #5

Open
Aliscans opened this issue Aug 7, 2020 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@Aliscans
Copy link

Aliscans commented Aug 7, 2020

I've attached a dump for a character with level 10.5 in Polearms, which gives level 6.6 in Axes and Staves. The character has not trained Axes or Staves, so these are not listed in the dump file.

dcssfamiliar displays these skills as being 0, and appears to treat it being 0 (changing the Polearms skill doesn't affect the damage from the staff).

I appreciate that working out cross trained skills is complicated, and it may not be worth fixing, but I thought I should mention it.
Iploisch.txt

@lmorao
Copy link
Owner

lmorao commented Aug 12, 2020

Hi Aliscans,

To implement cross training we probably need to have a way to enable/disable it (since it might get in the way for some types of comparisons), and we should implement it with a bigger feature to calculate experience. I thought about it, maybe at some point it can be added.

As you pointed out, if we never train a skill the cross training does not show up in the morgue. I'll have to leave that one for later, for once there's a function that calculates it for a bigger feature like the experience calculator.

In any case, thank you for bringing this up as an issue.

@lmorao lmorao added the enhancement New feature or request label Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants