From 213bc42d3e2cb9d4597542120c1b28c0020bd5bf Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Fri, 16 Feb 2024 22:55:26 -0800 Subject: [PATCH] [Tests] use `define-{accessor,data}-property` --- package.json | 2 ++ test/helpers/OwnPropertyKeys.js | 11 ++++++----- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index b59df7d0..b88b7187 100644 --- a/package.json +++ b/package.json @@ -107,6 +107,8 @@ "aud": "^2.0.4", "available-regexp-flags": "^1.0.2", "cheerio": "=1.0.0-rc.3", + "define-accessor-property": "^1.0.0", + "define-data-property": "^1.1.4", "diff": "^5.1.0", "eclint": "^2.8.1", "es-value-fixtures": "^1.4.2", diff --git a/test/helpers/OwnPropertyKeys.js b/test/helpers/OwnPropertyKeys.js index 9948af5b..3c8d72a4 100644 --- a/test/helpers/OwnPropertyKeys.js +++ b/test/helpers/OwnPropertyKeys.js @@ -3,9 +3,10 @@ var test = require('tape'); var hasSymbols = require('has-symbols')(); var $defineProperty = require('es-define-property'); +var defineAccessorProperty = require('define-accessor-property'); +var defineDataProperty = require('define-data-property'); var OwnPropertyKeys = require('../../helpers/OwnPropertyKeys'); -var defineProperty = require('./defineProperty'); test('OwnPropertyKeys', function (t) { t.deepEqual(OwnPropertyKeys({ a: 1, b: 2 }).sort(), ['a', 'b'].sort(), 'returns own string keys'); @@ -22,12 +23,12 @@ test('OwnPropertyKeys', function (t) { t.test('non-enumerables', { skip: !$defineProperty }, function (st) { var o = { a: 1, b: 42, c: NaN }; - defineProperty(o, 'b', { enumerable: false, value: 42 }); - defineProperty(o, 'c', { enumerable: false, get: function () { return NaN; } }); + defineDataProperty(o, 'b', { nonEnumerable: true, value: 42 }); + defineAccessorProperty(o, 'c', { nonEnumerable: true, get: function () { return NaN; } }); if (hasSymbols) { - defineProperty(o, 'd', { enumerable: false, value: true }); - defineProperty(o, 'e', { enumerable: false, get: function () { return true; } }); + defineDataProperty(o, 'd', { nonEnumerable: true, value: true }); + defineAccessorProperty(o, 'e', { nonEnumerable: true, get: function () { return true; } }); } st.deepEqual(