Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robot txt params may fail to read depending on system locale #53

Open
ElteHupkes opened this issue Jul 24, 2016 · 0 comments · May be fixed by #62
Open

Robot txt params may fail to read depending on system locale #53

ElteHupkes opened this issue Jul 24, 2016 · 0 comments · May be fixed by #62
Labels
bug

Comments

@ElteHupkes
Copy link

In a nutshell (because I'm in a hurry, also the reason you're not getting a pull request, sorry): std::atof() is locale dependent, and may expect a comma as a decimal separator. This may truncate all sorts of values read by RobotRepresentation.cpp into their integer parts or multiply them by several orders of magnitude depending on the number of digits. Apparently my fully English Ubuntu 14.04 still has a Dutch locale setting for numbers, which is why I noticed this issue.

Possible solutions here: http://stackoverflow.com/questions/1333451/locale-independent-atof/1333534#1333534
aliceconcordel added a commit to aliceconcordel/robogen that referenced this issue Oct 31, 2016
@aliceconcordel
replaced std::atof by ParsingUtils::parse_float and ParsingUtils::par…
5185470 
…se_double to avoid dependency on locale

this fixes lis-epfl#53
@aliceconcordel aliceconcordel linked a pull request Oct 31, 2016 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replaced std::atof aliceconcordel/robogen
2 participants
@ElteHupkes @basil-huber