Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify non-conformant JSON in tests #24

Closed
billgeo opened this issue Sep 15, 2021 · 2 comments
Closed

Verify non-conformant JSON in tests #24

billgeo opened this issue Sep 15, 2021 · 2 comments
Assignees

Comments

@billgeo
Copy link
Contributor

billgeo commented Sep 15, 2021

So that we can ensure schemas are working as expected, it would be good to add the ability to test non-conformant JSON examples against the schema to the 'template' extension.

  • discuss with community to get examples
  • implement in a LINZ extension

Related: Proposal: Non-conformant examples

@billgeo
Copy link
Contributor Author

billgeo commented Sep 15, 2021

The manual testing website I used recently. https://www.jsonschemavalidator.net/

Looks like it's .net though. :(

@MitchellPaff MitchellPaff self-assigned this Sep 16, 2021
@billgeo
Copy link
Contributor Author

billgeo commented Sep 23, 2021

Hey @MitchellPaff . Haven't had a chance to play with the bash script, but it doesn't look like this is part of a CI job? Am I missing something about that? Or were you thinking that was different story?

If it is part of a CI job, can you send me a link to an example?

Otherwise I'll test it when I'm back from leave. But in general, if you and Victor are happy that this is working then we can probably close it. Seeing as it's a quality enablement type feature then if you guys are happy that it's improving quality, then I'm happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants