Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Login Page #119

Closed
1 task done
dimmujed opened this issue Jan 4, 2024 · 6 comments
Closed
1 task done

[FEAT] Login Page #119

dimmujed opened this issue Jan 4, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@dimmujed
Copy link

dimmujed commented Jan 4, 2024

Is this a new feature request?

  • I have searched the existing issues

Wanted change

A login page with some kind of basic authentication would be great for this, as that would allow it to be exposed to the internet w/o having to deal with copyright issues. I know there are ways to do it via other apps, but it seems like a rather complicated setup for one item.

Reason for change

Privacy, plus you can make it so it auto sets the user profile with their saves.

Proposed code change

No response

@dimmujed dimmujed added the enhancement New feature or request label Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@thelamer
Copy link
Member

thelamer commented Jan 4, 2024

This container runs on http port 80 and 3000 without ssl intentionally, for outside world access to any of your apps always use a reverse proxy I recommend SWAG https://github.com/linuxserver/docker-swag

@thelamer thelamer transferred this issue from linuxserver/docker-emulatorjs Jan 8, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Non-Docker Issues in Issue & PR Tracker Jan 8, 2024
@gr33k
Copy link

gr33k commented Jan 9, 2024

I wanted to do the same thing to protect my public facing site...as I've read that security is not tested on this thing as it is intended to be use on a LAN (fair enough). SOOoooo.....I want to share it only with my friends. Using NGINX I created a basic auth for this purpose and it works fine:

server {
    server_name your.website.com;

#Basic Aut
    auth_basic           "Cool Gamers Only";
    auth_basic_user_file /data/Containers/emulatorjs/nginx/.htpasswd;

    location / {
        proxy_pass http://192.168.0.10:80;
    }

Hope this helps!

@gr33k
Copy link

gr33k commented Jan 9, 2024

Also to note - this is a dupe of #114

@thelamer
Copy link
Member

Linking note #114 (comment)

@thelamer
Copy link
Member

I have decided against this, anyone with a home server should be putting this behind a reverse proxy of some kind. I am not security focused and any authentication layer added would be to keep the kids out not the internet. When people land on apps and have root level access they understand that they cannot expose them to the internet. When you add auth you are indirectly saying I have secured this application even if not communicating that directly.

@LinuxServer-CI LinuxServer-CI moved this from Non-Docker Issues to Done in Issue & PR Tracker Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants