-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-compose pull results in error #2
Comments
Our readme does not say :latest is a valid tag |
As per our readme, there is only a nightly tag: https://github.com/linuxserver/docker-readarr#version-tags |
but the readme does say there is a latest in the recommended compose part it doesn't add a tag which results in latest |
Those are examples: The recommended is suggesting that compose is our recommended deployment method. You should still be checking what tags are available in the table above. |
Yes sure but an example that doesn't work is a bad or at least missleading. If there is only one tag wouldn't it be better to added that tag to the example. But I don't wanted to sound ungrateful I am thankful for your work keep it up! |
The reasoning for it being the way it is, is because Readarr is still beta, and it's not guaranteed to work the way you may expect (but it also isn't guaranteed to break). Having a user not blindly follow a example helps us make sure the user is somewhat invested in this. |
The readme could still be improved regardless |
the Contributing document says to edit the readme-vars.yml but there is no readme-vars.yml file to modify to fix the ReadMe file. The Usage section of the current ReadMe file has docker-compose and docker CLI setups that do not work (because Latest is not a valid Tag, as mentioned above). The Image is specified as It looks like switching to There are several other places on the Readme that also mention JUST So, I'm not sure if we need to just edit the Readme.md directly right now, or figure out what to put in the readme-vars.yml to match the existing Readme.md. Is there something to describe the build process for the readme, so we can fix it? |
This is done with intention, readarr is in beta, so we highly recommend users to read and understand the readme, which does state which tags are active. |
Ah, so it's intentionally left with broken commands and no direct explanation because you only want people who can put together that If you don't want people to follow examples - just remove the examples |
They are just that, examples. |
Came here to figure this out. Honestly, I'd probably leave the image tag on the sample docker-compose file to something that's working, even though it's in beta. IMHO Better to have an off the bat working docker-compose file and some explanation about the tag usage than have (potentially) some folks drop out from frustration. |
I just ran into this. The README of this container says both:
and
Yet this repository has no
That is fine, but we expect the readme to be understandable. This means not telling people that they can "simply pull |
Neither statement is incorrect. The first statement is only about The table under Our readmes are templated and contain generalized statements that may not apply to all the images (they apply to a great majority). However they are rarely incorrect. You can also browse all the tags available on ghcr, docker hub, gitlab or quay.io. |
I see, thank you for replying |
Using your sample docker-compose.yml iun your
readme.md
, when doingdocker-compose pull
I get:If I change the image to simply linuxserver/readarr, I get:
The text was updated successfully, but these errors were encountered: