Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose pull results in error #2

Closed
teejo75 opened this issue Jul 31, 2021 · 16 comments
Closed

docker-compose pull results in error #2

teejo75 opened this issue Jul 31, 2021 · 16 comments

Comments

@teejo75
Copy link

teejo75 commented Jul 31, 2021

Using your sample docker-compose.yml iun your readme.md, when doing docker-compose pull I get:

Pulling readarr ... error

ERROR: for readarr  name unknown
ERROR: name unknown

If I change the image to simply linuxserver/readarr, I get:

Pulling readarr ... error

ERROR: for readarr  manifest for linuxserver/readarr:latest not found: manifest unknown: manifest unknown
ERROR: manifest for linuxserver/readarr:latest not found: manifest unknown: manifest unknown
@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

@Roxedus
Copy link
Member

Roxedus commented Jul 31, 2021

Our readme does not say :latest is a valid tag

@Roxedus Roxedus closed this as completed Jul 31, 2021
@j0nnymoe
Copy link
Member

As per our readme, there is only a nightly tag: https://github.com/linuxserver/docker-readarr#version-tags

@Roxedus Roxedus pinned this issue Jul 31, 2021
@NemesisRE
Copy link

but the readme does say there is a latest in the recommended compose part it doesn't add a tag which results in latest
https://github.com/linuxserver/docker-readarr#docker-compose-recommended-click-here-for-more-info

@j0nnymoe
Copy link
Member

Those are examples: Here are some example snippets to help you get started creating a container.

The recommended is suggesting that compose is our recommended deployment method. You should still be checking what tags are available in the table above.

@NemesisRE
Copy link

Yes sure but an example that doesn't work is a bad or at least missleading. If there is only one tag wouldn't it be better to added that tag to the example.
On the other hand if there is only one tag it's also the latest so you could double tag nightly with latest until you switch it to a production version.
It is just an suggestion IMHO an example should work to be an example.

But I don't wanted to sound ungrateful I am thankful for your work keep it up!

@Roxedus
Copy link
Member

Roxedus commented Aug 16, 2021

The reasoning for it being the way it is, is because Readarr is still beta, and it's not guaranteed to work the way you may expect (but it also isn't guaranteed to break). Having a user not blindly follow a example helps us make sure the user is somewhat invested in this.

@facorazza
Copy link

The readme could still be improved regardless

@PsychoData
Copy link

@Roxedus

the Contributing document says to edit the readme-vars.yml but there is no readme-vars.yml file to modify to fix the ReadMe file.

The Usage section of the current ReadMe file has docker-compose and docker CLI setups that do not work (because Latest is not a valid Tag, as mentioned above). The Image is specified as ghcr.io/linuxserver/readarr which doesn't handle the need to use :nightly .

It looks like switching to ghcr.io/linuxserver/readarr:nightly will at least make it so that the commands on the readme page will work - and it could be tweaked back to ghcr.io/linuxserver/readarr with no tag whenever it is time for normal release.

There are several other places on the Readme that also mention JUST ghcr.io/linuxserver/readarr or linuxserver/readarr or readarr where it also should get changed if you want the commands mentioned on the Readme page to be correct/work.

So, I'm not sure if we need to just edit the Readme.md directly right now, or figure out what to put in the readme-vars.yml to match the existing Readme.md. Is there something to describe the build process for the readme, so we can fix it?

@Roxedus
Copy link
Member

Roxedus commented Oct 2, 2021

This is done with intention, readarr is in beta, so we highly recommend users to read and understand the readme, which does state which tags are active.

@PsychoData
Copy link

Ah, so it's intentionally left with broken commands and no direct explanation because you only want people who can put together that docker pull linuxserver/readarr is going to pull :latest by default - and since :latest is NOT listed that is why all of the examples are broken.

If you don't want people to follow examples - just remove the examples

@Roxedus
Copy link
Member

Roxedus commented Oct 3, 2021

They are just that, examples.

@jt196
Copy link

jt196 commented Nov 22, 2021

Came here to figure this out.

Honestly, I'd probably leave the image tag on the sample docker-compose file to something that's working, even though it's in beta.

IMHO Better to have an off the bat working docker-compose file and some explanation about the tag usage than have (potentially) some folks drop out from frustration.

@MitchTalmadge
Copy link

MitchTalmadge commented Dec 16, 2021

I just ran into this. The README of this container says both:

Simply pulling ghcr.io/linuxserver/readarr should retrieve the correct image for your arch

and

latest tag usually provides the latest stable version.

Yet this repository has no latest tag; both of those statements are incorrect and/or misleading.

we highly recommend users to read and understand the readme

That is fine, but we expect the readme to be understandable. This means not telling people that they can "simply pull ghcr.io/linuxserver/readarr" or mentioning the latest tag when it does not exist.

@aptalca
Copy link
Member

aptalca commented Dec 16, 2021

Neither statement is incorrect. The first statement is only about arch, as in you don't need an arch specific tag like nightly-arm32v7. The second one simply states latest usually provides the latest stable. This (upstream) project does not have a stable release, thus no latest tag. When there is a stable upstream release, there will be a latest tag.

The table under Version Tags lists all available tags.

Our readmes are templated and contain generalized statements that may not apply to all the images (they apply to a great majority). However they are rarely incorrect.

You can also browse all the tags available on ghcr, docker hub, gitlab or quay.io.
Here's the ghcr page: https://github.com/linuxserver/docker-readarr/pkgs/container/readarr

@MitchTalmadge
Copy link

I see, thank you for replying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants