Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mips64 disable compile unit test binaries #267

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Zeno-sole
Copy link
Contributor

mips64 disable compile unit test binaries

Log: mips64 disable compile unit test binaries

deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Jan 6, 2025
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#267
Copy link
Contributor

@mhduiy mhduiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete CMakeCache.txt

CMakeLists.txt Outdated Show resolved Hide resolved
deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Jan 6, 2025
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#267
mips64 disable compile unit test binaries

Log: mips64 disable compile unit test binaries
deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Jan 6, 2025
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#267
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • CMakeLists.txt文件中,增加了对mips64处理器的支持,这是一个好的改进,因为它扩展了项目的兼容性。

是否建议立即修改:

  • 否,当前提交的修改没有明显的错误或问题,可以接受。但是,建议进行以下额外的检查和改进:
  1. 代码注释:建议在修改后的条件判断中添加注释,说明为什么需要支持mips64处理器,以及这样做的好处。
  2. 测试覆盖:确保在添加对新处理器的支持后,进行充分的测试,以确保代码的正确性和稳定性。
  3. 文档更新:如果这是一个新添加的功能,建议更新项目的文档,说明对mips64处理器的支持,以及如何启用和配置相关的测试。

其他建议:

  • 考虑将CMAKE_SYSTEM_PROCESSOR的值存储在一个变量中,以避免重复使用,提高代码的可读性和可维护性。
  • 如果项目中有多个地方需要检查处理器类型,可以考虑创建一个函数来封装这个逻辑,以减少代码重复。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, Zeno-sole

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit ee7a8e3 into linuxdeepin:master Jan 6, 2025
17 of 20 checks passed
mhduiy pushed a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Jan 6, 2025
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants