Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.14 #35

Merged
merged 2 commits into from
Jan 7, 2025
Merged

1.0.14 #35

merged 2 commits into from
Jan 7, 2025

Conversation

Johnson-zs
Copy link
Contributor

No description provided.

as title

Log: as title
1.0.14

Log: tag 1.0.14
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. changelog 文件:

    • changelog 文件中,新增了一个版本号 1.0.14,但未提供具体的更改内容。建议在提交信息中详细说明修复了哪些 bug 或进行了哪些改进。
    • urgency 标签设置为 medium,如果这是一个重大修复,建议将其设置为 high
  2. docparser.pc.in 文件:

    • docparser.pc.in 文件中,includedir 的路径被修改为 ${prefix}/@CMAKE_INSTALL_INCLUDEDIR@/docparser。这可能会导致在安装时,头文件路径不正确。建议确认这个路径是否正确,或者是否需要调整安装脚本。
    • Cflags 行末尾的空格被移除,这是一个好的实践,可以避免潜在的空格问题。

总体来说,代码的修改看起来是合理的,但需要确保路径和提交信息是准确的。

Copy link

github-actions bot commented Jan 7, 2025

TAG Bot

TAG: 1.0.14
EXISTED: no
DISTRIBUTION: UNRELEASED

@Johnson-zs
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 7, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 4df044d into linuxdeepin:master Jan 7, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants